Arm backend: Stabilize VGF bilinear fp16 test#19613
Merged
Merged
Conversation
This patch fixes a flaky VGF no-quant Interpolate test for upsample_bilinear2d fp16 inputs. The neighboring VGF Upsample test already uses looser fp16 comparison tolerances, while the Interpolate variant still used the default 1e-3 atol/rtol. The observed fp16 output difference can be slightly above that default threshold. Match the Upsample behavior by using 1e-2 atol/rtol for fp16 inputs and keeping 1e-3 atol/rtol for other dtypes. The change was verified with collection of the targeted VGF Interpolate pytest cases. Signed-off-by: Baris Demir <baris.demir@arm.com> Change-Id: I83e62f2241d418100d3fa9df5883b2935bd751a1
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19613
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 3 Unrelated FailuresAs of commit 3cbce72 with merge base 803e47d ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Collaborator
Author
|
@pytorchbot label "partner: arm" |
pytorch-bot
Bot
added
the
partner: arm
Collaborator
Author
|
@pytorchbot label "release notes: arm" |
zingo
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani